Aaron Marcher
c4779c9b15
Removed #define for unknown_str
Debugging #define is very difficult. The performance overhead of static const
char is negligible.
7 years ago
Aaron Marcher
be12b6b350
Removed #define for update interval
Debugging #define, especially in mathematical constructs is very
difficult. The performance overhead of static const int is negligible.
7 years ago
Ali H. Fardan
2c114ec2b5
keyboard_indicators: fix segfault when -s is specified
7 years ago
Aaron Marcher
6f01174392
Fixed possible NULL-deref and removed unnecessary XOpenDisplay()
- Added a check for the return value of XOpenDisplay() in main().
This fixes a possible NULL-deref.
- Removed unnsecessary XOpenDisplay and XCloseDisplay from
keyboard_indicators(). The ones in main() are sufficent.
7 years ago
Laslo Hunhold
1814061396
Add and use LEN() macro
7 years ago
Laslo Hunhold
178c23e3d2
Refactor battery_state()
7 years ago
Laslo Hunhold
00ce7a746a
Print usage() when we are left with arguments
7 years ago
Laslo Hunhold
c9d47405f4
Reduce -o | -n to -s
What we really want is to either output to WM_NAME or stdout. If we want
just one single line, we do slstatus | head -n 1.
7 years ago
Laslo Hunhold
4d33c36014
Remove d- and v-flags
d-flag: There's no need for that, use the &-operator or fork+exec in a
non-shell-context. In the latter case you get the PID for free.
v-flag: If you want to find out which version of a package is installed,
consult your package manager. That's his job.
7 years ago
Laslo Hunhold
958c34052a
Convert slstatus.1 to mandoc, simplify it and remove -h
We also change the semantics of -v to only return the version
information.
There is now no need for usage() to exit with anything other than 1.
7 years ago
aaron marcher
4b4b2ac079
add num_files() function for maildirs ;)
7 years ago
Aaron Marcher
1c8aa5318f
check for fgets/fscanf return values
7 years ago
Aaron Marcher
597cdc6b5c
use a static buffer instead of dynamic memory
7 years ago
Aaron Marcher
abbaa7af44
remove format characters from stat functions
7 years ago
Aaron Marcher
832b21ca4b
add cpu_freq function
7 years ago
Aaron Marcher
259e967cbf
add battery_power function
7 years ago
Aaron Marcher
870d68d44e
added option to output only once and exit afterwards
7 years ago
Aaron Marcher
d144c8de3d
simplified and improved vol_perc()
7 years ago
Aaron Marcher
c288663ebd
fix overflow in run_command()
7 years ago
Aaron Marcher
b2714032e5
username(): get rid of unneeded uid variable
7 years ago
Tobias Stoeckmann
35295f1902
On success, fgets always terminates the result.
If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
7 years ago
Tobias Stoeckmann
b1e7c40b21
Fixed out of boundary write on long lines.
The terminating nul character ('\0') could be written outside the boundary of
the buffer which is used to read characters. If "sizeof(buffer)" characters
are read, the resulting value must not be used as index, because that's an off
by one.
Read sizeof(buffer)-1 bytes instead.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
7 years ago
Aaron Marcher
cceeec0efa
loading thresholds state
7 years ago
Aaron Marcher
b11dd2db0e
Fixed XCloseDisplay() which is not reached in keyboard_indicators()
7 years ago
Aaron Marcher
823f2d047f
Added keyboard_indicators ( Fixes #31 )
7 years ago
Aaron Marcher
3f976aabc0
Makefile fix and vol_perc fix for mute
7 years ago
Aaron Marcher
0d1f19d777
removed ./extern/
7 years ago
Aaron Marcher
688e2e783d
removed strlcat dependency (was used only once)
7 years ago
Aaron Marcher
32bb92453a
got rid of concat.h
7 years ago
Aaron Marcher
3847911771
happy new year!
7 years ago
Aaron Marcher
8a29374783
run_command: strlen() will not function if string is not null terminated
7 years ago
Aaron Marcher
965a71d678
consistent coding style: usage() declaration, eval is a constant
7 years ago
parazyd
62f4016430
add vol_perc notes, add braces to singleline statements
7 years ago
Aaron Marcher
8fa6229759
why releases for such a small project? useless and overhead!
7 years ago
Aaron Marcher
b68925dbef
#undef strlcpy not needed anymore
7 years ago
raiz
b231cd90eb
add braces to single statements so drkhsh doesn't be upset
7 years ago
Aaron Marcher
7392dbabeb
kernel_release() coding style and position in code fix
7 years ago
parazyd
c2808b6d99
refactor vol_perc to not depend on alsa libraries
7 years ago
raiz
cfb4a5d3ff
usage(): return success if -h is called && print more appropriate usage, opts can't be all called at the same time, that's why a separator is required
7 years ago
raiz
e9f738b8b6
whhops, my bad
7 years ago
raiz
94e87eb8ba
wifi_essid: add boundary check && prevent the use of direct string literal as a format string in snprintf()
7 years ago
raiz
11fec4fa95
don't allow the use of perc if uninitialized
7 years ago
raiz
8b5b72b65e
remove misleading comment
7 years ago
raiz
13772c3979
get rid of set_status() since it's only used once
7 years ago
raiz
3c8717f4e0
allow the use of %* symbols in UNKNOWN_STR
7 years ago
raiz
7db4f5cf67
add extra error tests to swap_*() && fix bytes_read bug
7 years ago
raiz
a36cb96f27
swap_*(): add more error tests
7 years ago
raiz
862d158b7c
fix delay in a cleaner way
7 years ago
raiz
6cab2d5719
remove newlines from warn() in swap_*(), those functions already print a newline after printing string stderr
7 years ago
raiz
e1c5476291
inititalize run_command()'s buf to UNKNOWN_STR by default
7 years ago